Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BE | Refactor SessionsController#create & #destroy Endpoints #68

Merged
merged 7 commits into from
Oct 30, 2023
Merged

BE | Refactor SessionsController#create & #destroy Endpoints #68

merged 7 commits into from
Oct 30, 2023

Conversation

MelTravelz
Copy link
Contributor

Changes:

  • Refactored Sessions#create & created helper method #authenticate_user
  • Created 3 new exceptions for authorization (see application controller)
  • Refactored Sesssion#destory helper method #authorize for more consistent error handling
  • Updated all tests & created sad path test for #destroy

This is related to #

This closes #67

[] I linted my work. (RuboCop)

[] I've updated documentation & README. (if necessary)

(For Fun!) Please include a link to a meme/gif of your feelings about this branch!

Link:
what-do-you-5c4be1

@MelTravelz MelTravelz self-assigned this Oct 30, 2023
@MelTravelz MelTravelz changed the title 3refactor BE | Refactor SessionsController#create & #destroy Endpoints Oct 30, 2023
@MelTravelz MelTravelz merged commit c7eded6 into main Oct 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MelTravelz MelTravelz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BE | Refactor SessionController#create & #destroy
1 participant
@MelTravelz